fix sonar problem

* replace min limit value with const values
* remove duplicated testcase and add testcase
* put together switch case statement
* fill empty block of code
This commit is contained in:
t29kida
2021-05-29 23:48:17 +09:00
parent 2f174db197
commit de65d82701
4 changed files with 23 additions and 25 deletions

View File

@@ -120,25 +120,21 @@ func TestOrder_GetColumn(t *testing.T) {
}
}
func TestOrder_GetSort(t *testing.T) {
o := Clause(
SortDescending(),
)
if o.GetSort() != Descending {
t.Error()
}
}
func TestSortString(t *testing.T) {
template := "got: %s, want: %s"
func TestOrder_IsRaw(t *testing.T) {
o1 := Clause()
if o1.IsRaw() {
t.Error()
o1 := Clause(sort(Sort(1)))
if o1.SortString() != "ASC" {
t.Errorf(template, o1.SortString(), "ASC")
}
o2 := Clause(
Raw(),
)
if !o2.IsRaw() {
t.Error()
o2 := Clause(sort(Sort(2)))
if o2.SortString() != "DESC" {
t.Errorf(template, o2.SortString(), "DESC")
}
o3 := Clause(sort(Sort(3)))
if o3.SortString() != `` {
t.Errorf(template, o3.SortString(), ``)
}
}